NW6/Fidaa Bashir/HTML-CSS/bikes-for-refugees/Week 1 #475
Conversation
✅ Deploy Preview for cyf-bfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fidaabashir89
changed the title
index.html
Outdated
| <img src="./images/bikes-for-refugees_logo.jpg" alt="Logo for Bikes for Refugees Scotland" class="header__logo" /> | ||
| </a> | ||
|
|
||
| <nav> |
There was a problem hiding this comment.
Really good to see you diving straight in and doing the sematic HTML work Looking good!
| <h2 class="heading-underline">Upcoming events</h2> | ||
|
|
||
| <article class="article"> | ||
| <img class="article__thumbnail" src="./images/spring-fundraisers_thumbnail.jpg" alt="fundraisers" /> |
| @@ -94,8 +103,36 @@ p { | |||
|
|
|||
|
|
|||
| /* Buttons */ | |||
| button { | |||
| border-radius: 0.3rem; | |||
There was a problem hiding this comment.
I really love the way you've made this style, it's professional looking and you've used CSS varibles and classes to avoid reuse of coe. Objective 3 complete!
| background-color: var(--grey-light); | ||
| padding: 6rem 3rem; |
There was a problem hiding this comment.
Very nice, good that you used rem over px - this was a CYF best practice last I heard
| } | ||
|
|
||
| .navigation__item:hover { | ||
| background-color: #c05326; |
There was a problem hiding this comment.
You did the stretch goals to! Nice! Should also have been a var maybe, though this a matter of your own prefrences wher're you're only using it once
|
Thank you @Ara225 for your code review. I've moved the nav bar to the right position as requested :) |
|
Brillant looking good :) |
No description provided.